Results 41 to 50 of 396
-
09-26-2014, 02:54 PM #41
-
09-26-2014, 06:29 PM #42
Dacb:
May I ask for a couple more changes to your fork? There are 3 items. First, can we put this in the Configuration.h file?
Code:// set the max number of grid points per dimension // The G29 command defaults to 3 if nothing is specified. But setting the number of probed // points higher is very useful when getting a Bed Topology Report (G29 n 5 T) #define AUTO_BED_LEVELING_GRID_POINTS 5 // Uncomment one of the following four lines so the Bed Topology Report can produce a map // that relates accurately to your bed orientation. #define ORIGIN_FRONT_LEFT //#define ORIGIN_BACK_LEFT //#define ORIGIN_FRONT_RIGHT //#define ORIGIN_BACK_RIGHT
The other change I'm hoping you can paste into your fork is a comment block in front of the G29 command. It will help people understand how to use it. Unfortunately, this isn't complete. We will probably want to add some more comments about getting the post processing setup for different slicers but I guess that can wait until we have that done.
Code:#ifdef ENABLE_AUTO_BED_LEVELING // // Enhanced G29 Auto Bed Leveling Probe Routine // // This updated code provides a Bed Topology Report, Ability to control engagement and retraction of // Z-Probe and varying levels of verboseness. It also allows the selection of the n x n grid at // print time instead of being fixed at the time the firmware is built. It also handles probe retraction // issues for probes that require clearance much more gracefully. // // Parameter usage: // // n (u & U) Controls the size of the grid that will be probed. Typical usage would be of // the form G29 n 4 u & U were added because of deficiencies in the Repetier client // not being able to use even a lower case n // // V Controls the verbose level. Typical usage would be of the form G29 V 3 // // T Controls generation of the Bed Topology Report. Typical usage would be of the // form G29 n 5 T to get a detailed map of your bed. This is very useful // for manual bed leveling as well as knowing where imperfections exist on your // bed (to assist with part placement) // // E Controls engagement and retraction of the Z-Probe. It Defaults to leaving the // probe engaged during the probing of the n x n grid. This helps the repeatability // of the Z-Probe and produces better Auto Bed Leveling results. Typical usage // would be of the form G29 E // // These following 4 parameters are typically generated by a Post Processing script // configured within your slicer to process the generated GCode. Currently Curra and // Slic3r are supported. The Post Processing scripts for these slicers will determine the // size of the print on the bed and limit the Grid Probe to the required region in order to // increase the bed leveling accuracy. Please not that these position parameters assume // Left is the smallest X-Axis coordinate, Right is the larger X-Axis coordinate and Front is // the smallest Y-Axis coordinate and Back is the larger Y-Axis coordinate. // // L Controls left side grid probe position. If unspecified, will use LEFT_PROBE_BED_POSITION // // R Controls the right side grid probe position. If unspecified, will use RIGHT_PROBE_BED_POSITION // // F Controls front side grid probe position. If unspecified, will use FRONT_PROBE_BED_POSITION // // B Controls the back side grid probe position. If unspecified, will use BACK_PROBE_BED_POSITION // // case 29: // G29 Detailed Z-Probe, probes the bed at 3 or more points. // Example Syntax: G29 n 4 V 2 E T L 50 R 150 F 25 B 125 {
THANKS!!!!Last edited by Roxy; 09-26-2014 at 07:31 PM.
-
09-26-2014, 08:15 PM #43
Nice work... Comments / documentation is super important. Here is the commit: https://github.com/beckdac/Marlin/co...32f725c23ab670
-
09-26-2014, 08:44 PM #44
- Join Date
- Jul 2014
- Location
- Eastern Colorado
- Posts
- 536
Roxy, that comment block explaining the different arguments passed to G29, the one for E is not clear to me. If one uses E, what should they expect to see? From what I've seen in your Probe Repeatability test, E caused the servo to lift the probe each time. In this comment block, though, it sounds like it's used to keep the probe extended for the duration of probing.
-
09-26-2014, 10:32 PM #45
So I can't speak definitely! I haven't run this code yet. I'm going to have to port it back to my machine. But the Enhanced G29 is supposed to leave the probe down while taking all the points by default. Specifying the E option should make it go back to the original behavior and 'E'ngage the probe and un-'E'ngage the probe for each point.
The comment says:
Code:Controls engagement and retraction of the Z-Probe. It Defaults to leaving the probe engaged during the probing of the n x n grid.
With nothing specified, the default behavior is to leave the probe engaged.
Please feel free to help make the documentation clearer! For sure people writing code make assumptions about what is obvious and what is not obvious. And if you do make the comments better... Maybe you can make the Left, Right, Front, Back comments better! The big problem with that is it assumes the origin for the person's bed is at the left front. That is not always the case. (I'm exactly opposite to that because of early flaws in the G29 code where it could not take negative offsets) But what can be done (either by switching the option names or by a different explanation) to make that better?
-
09-26-2014, 10:59 PM #46
Yes, this is the biggest problem right now. It won't affect anyone in the MakerFarm family, so far as I know, but it does prevent the change from being pushed back to trunk without further consideration. I think it will also have an impact on any post-processing scripts. This really makes me want to rename or reannotate the L, F, R, B parameters to reflect that they are really Xmin, Ymin, Xmax, Ymax.
BTW, if anyone wants to get added as a contributor to the repo, just drop me a private message.
-
09-26-2014, 11:23 PM #47
- Join Date
- Jul 2014
- Location
- Eastern Colorado
- Posts
- 536
I would say
Code:// E Causes the Z-Probe to Engage and retract with every probe point. Do not use if you want to leave the // probe Engaged during the probing of the n x n grid. Leaving the probe Engaged helps the repeatability // of the Z-Probe and produces better Auto Bed Leveling results. Typical usage // would be of the form G29 E
Maybe you can make the Left, Right, Front, Back comments better! The big problem with that is it assumes the origin for the person's bed is at the left front. That is not always the case. (I'm exactly opposite to that because of early flaws in the G29 code where it could not take negative offsets) But what can be done (either by switching the option names or by a different explanation) to make that better?Last edited by AbuMaia; 09-26-2014 at 11:37 PM.
-
09-26-2014, 11:36 PM #48
-
09-27-2014, 12:07 AM #49
- Join Date
- Jul 2014
- Location
- Eastern Colorado
- Posts
- 536
Would Delta and SCARA machines even use the G29 code?
-
09-27-2014, 08:08 AM #50
Printer will print perfect...
Yesterday, 10:44 AM in Tips, Tricks and Tech Help