Close



Results 1 to 10 of 396

Hybrid View

  1. #1
    Technologist dacb's Avatar
    Join Date
    Aug 2014
    Location
    Edmonds, WA
    Posts
    139
    OK, I integrated those changes into our fork: https://github.com/beckdac/Marlin/co...7dc766f4e76575

    Unfortunately, that code set also has a parameter (A) for supplying the number of points to probe and those changes break Roxy's code and conflict with that enhanced G29 parameter (n). So I created an additional patch to reconcile these two: https://github.com/beckdac/Marlin/co...e9d3bcc49fd4de

    I decided to keep the (n) parameter to G29 from Roxy and remove the (A) parameter. So an example G29 command could be:
    Code:
    G29 V4 T n3 L95 F95 R105 B105
    Where the highest level of verbosity is used, the topography is printed, the number of points is 3 in X and Y (3x3) and the print/ABL area is from 95,95 to 105,105.
    Last edited by dacb; 09-25-2014 at 10:59 PM.

  2. #2
    Super Moderator Roxy's Avatar
    Join Date
    Apr 2014
    Location
    Lone Star State
    Posts
    2,182
    Quote Originally Posted by dacb View Post
    I decided to keep the (n) parameter to G29 from Roxy and remove the (A) parameter. So an example G29 command could be:
    Code:
    G29 V4 T n3 L95 F95 R105 B105
    Holy Cow! That is great if you merged things that easily! And actually... I have a request. I think 'n' makes sense but because Repetier can't tolerate either n or N and Pronterface can't use a capital N, we need to accommodate something else. I'll look at the merge (and re-read these posts in detail) in the morning, but I already added :

    if ( code_seen('n') || code_seen('U') || code_seen('u') ) {
    n_points = code_value();
    if (n_points<2 || n_points>AUTO_BED_LEVELING_GRID_POINTS ) {
    SERIAL_PROTOCOLPGM("?Number of probed points not plausable.\n");
    break;
    }
    }

    to my code base to help with a transition. Can we fold that into the merge? I was thinking an upside down 'N' would be easy to remember if you are using broken software that can't tolerate an 'N'.
    Last edited by Roxy; 09-26-2014 at 01:21 AM.

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •