Results 1 to 10 of 172
Hybrid View
-
11-01-2014, 08:45 AM #1
Yeah, I was kind of torn which way to go. Doing what you did preserves the original behavior which has merit. It might be worth a quick discussion to decide if those extra #ifdef's should be added to the first post or not. Personally... I think the correction matrix should start off at Unity and not be affected by the G28. But there is so much legacy in place now that it isn't good to change things for no reason. I decided to make the changes as minimalistic as possible (which meant not adding the extra pre-processor commands). However, with that said, nobody is going to be typing that stuff in anyway. They are going to Cut & Paste it into their source, so there isn't any extra pain involved.
So should we alter the original post? If we do, and SAVE_G29_CORRECTION_MATRIX is not defined, everything will function the same as it used to behave.Last edited by Roxy; 11-01-2014 at 08:50 AM.
-
11-01-2014, 11:38 AM #2
- Join Date
- Jul 2014
- Location
- Eastern Colorado
- Posts
- 536
Only if you think there's a chance this code might eventually get pulled into the fork or "official" Marlin. As it is now, if someone wants to use it, they'll copy it in as it stands. My changes were for those who wanted to add the code, but not use it. A pretty small population I'd think.
I should have noticed the missing ;. I'm in the middle of a print right now, so I'll test how it prints out the matrix later.Last edited by AbuMaia; 11-01-2014 at 11:44 AM.
New to 3d printing looking for...
Yesterday, 12:56 AM in Tips, Tricks and Tech Help