Auto_Bed_Leveling: Enhanced G29 command

[brainscan]

echo:Home offset (mm):
echo: M206 X0.00 Y0.00 Z0.00
echo:PID settings:
echo: M301 P17.97 I1.25 D64.48
echo:SD card ok
SENDING:M80
>>>G29 n3 T V4
SENDING:G29 n3 T V4
Roxy's Enhanced G29 Auto_Bed_Leveling Code V1.01:
Bed x: 15.00 y: 10.00 z: -0.78
Bed x: 97.00 y: 10.00 z: -0.70
Bed x: 179.00 y: 10.00 z: -0.71
Bed x: 15.00 y: 100.00 z: -0.92
Bed x: 97.00 y: 100.00 z: -0.78
Bed x: 179.00 y: 100.00 z: -0.73
Bed x: 15.00 y: 190.00 z: -0.84
Bed x: 97.00 y: 190.00 z: -0.79
Bed x: 179.00 y: 190.00 z: -0.89
Eqn coefficients: a: 0.00 b: -0.00 d: -0.77
Mean of sampled points: -0.793750


Bed Height Topography:
--0.04648 +0.00000 --0.09336
--0.13008 +0.01484 +0.06523
+0.01484 +0.09570 +0.07930


planeNormal x: -0.00 y: 0.00 z: 1.00


Bed Level Correction Matrix:
1.000000 0.000000 0.000433
0.000000 1.000000 -0.000611
-0.000433 0.000611 1.000000
echo:endstops hit: Z:-0.89

Any good?

*I just did another one but using the safe homing where it homes in the middle of the bed, not so safe! It didn't do z lift before extending probe, luckily I already had enough space.

>>>G29 n3 T V4
SENDING:G29 n3 T V4
Roxy's Enhanced G29 Auto_Bed_Leveling Code V1.01:
Bed x: 15.00 y: 10.00 z: -0.71
Bed x: 97.00 y: 10.00 z: -0.70
Bed x: 179.00 y: 10.00 z: -0.76
Bed x: 15.00 y: 100.00 z: -0.82
Bed x: 97.00 y: 100.00 z: -0.77
Bed x: 179.00 y: 100.00 z: -0.77
Bed x: 15.00 y: 190.00 z: -0.75
Bed x: 97.00 y: 190.00 z: -0.74
Bed x: 179.00 y: 190.00 z: -0.89
Eqn coefficients: a: -0.00 b: -0.00 d: -0.70
Mean of sampled points: -0.770009


Bed Height Topography:
+0.02431 +0.02548 --0.11984
--0.05265 --0.00421 --0.00226
+0.05712 +0.06688 +0.00516


planeNormal x: 0.00 y: 0.00 z: 1.00


Bed Level Correction Matrix:
1.000000 0.000000 -0.000296
0.000000 1.000000 -0.000369
0.000296 0.000369 1.000000
echo:endstops hit: Z:-0.89

[Roxy]

It's way past my bed time... But in the morning I'll take a closer look at it. I'll figure out where to add a few extra lines of debugging code so we can zero in on where the problem is...

Update:

OK, I took your Marlin_main.cpp and dropped it into my build environment. I recompiled and flashed my firmware. Here is what I got when I sent it a G28 and then an M114 and a M48 command:

Connecting...
Printer is now online.
>>>G28
SENDING:G28
>>>M114
SENDING:M114
X:76.00 Y:73.00 Z:4.20 E:0.00 Count X: 76.00 Y:73.00 Z:4.20
>>>M48 V 4
SENDING:M48 V 4
M48 Z-Probe Repeatability test. Version 1.85
Positioning probe for the test.
1 of 10 z: 4.225065 mean: 4.225065 sigma: 0.000000
2 of 10 z: 4.214812 mean: 4.219938 sigma: 0.005126
3 of 10 z: 4.221096 mean: 4.220324 sigma: 0.004221
4 of 10 z: 4.217458 mean: 4.219607 sigma: 0.003860
5 of 10 z: 4.221426 mean: 4.219971 sigma: 0.003529
6 of 10 z: 4.213820 mean: 4.218946 sigma: 0.003954
7 of 10 z: 4.209851 mean: 4.217647 sigma: 0.004851
8 of 10 z: 4.206213 mean: 4.216217 sigma: 0.005906
9 of 10 z: 4.198276 mean: 4.214224 sigma: 0.007925
10 of 10 z: 4.203898 mean: 4.213191 sigma: 0.008131
Mean: 4.213191
Standard Deviation: 0.008131
echo:endstops hit: Z:4.20

My Z Probe offset is defined as:

#define Z_PROBE_OFFSET_FROM_EXTRUDER -4.20

so the code is returning a 'correct' value. Let's see a cut & paste of you doing the same 3 commands.

[brainscan]

>>>G28
SENDING:G28
>>>M114
SENDING:M114
X:84.00 Y:97.00 Z:-0.78 E:0.00 Count X: 84.00 Y:97.00 Z:-0.78
>>>M48 V4
SENDING:M48 V4
M48 Z-Probe Repeatability test. Version 1.85
Positioning probe for the test.
1 of 10 z: -0.767578 mean: -0.767578 sigma: 0.000000
2 of 10 z: -0.768359 mean: -0.767969 sigma: 0.000391
3 of 10 z: -0.767969 mean: -0.767969 sigma: 0.000319
4 of 10 z: -0.769531 mean: -0.768359 sigma: 0.000731
5 of 10 z: -0.771094 mean: -0.768906 sigma: 0.001274
6 of 10 z: -0.771094 mean: -0.769271 sigma: 0.001420
7 of 10 z: -0.771875 mean: -0.769643 sigma: 0.001600
8 of 10 z: -0.772266 mean: -0.769971 sigma: 0.001730
9 of 10 z: -0.772656 mean: -0.770269 sigma: 0.001836
10 of 10 z: -0.773047 mean: -0.770547 sigma: 0.001931
Mean: -0.770547
Standard Deviation: 0.001931
echo:endstops hit: Z:-0.77
>>>M114
SENDING:M114
X:84.00 Y:97.00 Z:-0.77 E:0.00 Count X: 84.00 Y:97.00 Z:9.23

I just thought i'd do another M114 to see where it thinks it is after the M48 and its totally different!?

**Just thought i'd run it again to make sure its a consistent result
>>>G28
SENDING:G28
>>>M114
SENDING:M114
X:84.00 Y:97.00 Z:-0.78 E:0.00 Count X: 84.00 Y:97.00 Z:-0.78
>>>M48 V4
SENDING:M48 V4
M48 Z-Probe Repeatability test. Version 1.85
Positioning probe for the test.
1 of 10 z: -0.767969 mean: -0.767969 sigma: 0.000000
2 of 10 z: -0.767578 mean: -0.767773 sigma: 0.000195
3 of 10 z: -0.769531 mean: -0.768359 sigma: 0.000844
4 of 10 z: -0.769141 mean: -0.768555 sigma: 0.000805
5 of 10 z: -0.769531 mean: -0.768750 sigma: 0.000819
6 of 10 z: -0.768750 mean: -0.768750 sigma: 0.000748
7 of 10 z: -0.769141 mean: -0.768806 sigma: 0.000706
8 of 10 z: -0.768750 mean: -0.768799 sigma: 0.000661
9 of 10 z: -0.768359 mean: -0.768750 sigma: 0.000638
10 of 10 z: -0.769922 mean: -0.768867 sigma: 0.000700
Mean: -0.768867
Standard Deviation: 0.000700
echo:endstops hit: Z:-0.77
>>>M114
SENDING:M114
X:84.00 Y:97.00 Z:-0.77 E:0.00 Count X: 84.00 Y:97.00 Z:9.23

[Roxy]

>>>G28
SENDING:G28
>>>M114
SENDING:M114
X:84.00 Y:97.00 Z:-0.78 E:0.00 Count X: 84.00 Y:97.00 Z:-0.78

I just thought i'd do another M114 to see where it thinks it is after the M48 and its totally different!?

**Just thought i'd run it again to make sure its a consistent result
>>>G28
SENDING:G28
>>>M114
SENDING:M114
X:84.00 Y:97.00 Z:-0.78 E:0.00 Count X: 84.00 Y:97.00 Z:-0.78

>>>M114
SENDING:M114
X:84.00 Y:97.00 Z:-0.77 E:0.00 Count X: 84.00 Y:97.00 Z:9.23

I don't understand why you say it is totally different? The M114 after the G28 is consistently reporting the nozzle to be at -.77 or so.

Right now... It looks like the code is behaving as it should. We need to understand things a little better.

Let's repeat the G28 and M114 with these changes:

#define Z_RAISE_BEFORE_HOMING 0 // (in mm) Raise Z before homing (G28) for Probe Clearance.
#define Z_RAISE_BEFORE_PROBING 0 //How much the extruder will be raised before traveling to the first probing point.
#define Z_RAISE_BETWEEN_PROBINGS 0 //How much the extruder will be raised when traveling from between next probing points

You should manually move the nozzle to a safe height after connecting before issuing the commands. This might help us understand where the strange values are coming from.

[brainscan]

The first M114 shows z -0.77 and after M48 z 9.23 which is much closer to what it should be even though it's in the same position when I issue the command.

I have no idea what the custom m code point thing is, I've tried raising it as a question on a few forums and no one has got back to me. I noticed it's in the main marlin code and was added a few months ago with absolutely no explanation as to what it does or how it affects the printer. I didn't want to comment it out incase it switched something vital off. I thought if it's in there with no explanation the developers must have felt it to be important. I will try what you've suggested and get back to you.

[Roxy]

The first M114 shows z -0.77 and after M48 z 9.23 which is much closer to what it should be even though it's in the same position when I issue the command.

I have no idea what the custom m code point thing is, I've tried raising it as a question on a few forums and no one has got back to me. I noticed it's in the main marlin code and was added a few months ago with absolutely no explanation as to what it does or how it affects the printer. I didn't want to comment it out incase it switched something vital off. I thought if it's in there with no explanation the developers must have felt it to be important. I will try what you've suggested and get back to you.

I edited out that comment about the CUSTOM_M_CODE. But I guess you saw the post before I did that. That code is benign if you don't send your printer an M851. I think it was in there to help the developer doing the bed leveling. It is in my code base (and everybody elses) too.

I think we want to concentrate on the G28 and the M114. That is the minimum code to cause the problem and we should be able to figure out what is causing your problem.

[Roxy]

Your 'Repeatability' is very good. The verbose print out says it knows Z is at -.76 when the probe fires. What numbers are you telling it to retract the Z by after and between probing. It doesn't make sense the final position varies. But my guess is the retraction numbers are factoring into this.

Did you figure out which corner your origin is in? Here is an easy way to do that. First, tell PronterFace to turn on the nozzle heat and let that settle. (It may be possible you don't have to do this... But this will work...) Do a G28 and let that finish. Then do a G1 X5.0 Y5.0 and see which corner it goes to.
That will be the origin.

[Roxy]

You will be deleting from the end of the case 28: code up to the case 30: statement. The end of the case 28: is the line that says case 29:

case 29: gets deleted and replaced by code in G29.cpp

But lets do it this way: Get the basic bed leveling going and working... I'll edit your files to have the enhanced stuff once that is working correctly.

[AbuMaia]

How does one set up Raise before Retract?

[Roxy]

How does one set up Raise before Retract?

That can be done with one or two lines of code in the right place. I really should add that to the Enhanced G29 code! Tell you what. I'll try to get that done before the weekend is over.