Auto_Bed_Leveling: Enhanced G29 command

[Roxy]

We have to do this in two steps. The reason is I have conflicting code in my Marlin_main.cpp file because I don't have an LCD Panel.

First, get and install Arduino v1.05 if you are not already using it. You can get it at: http://arduino.cc/en/Main/Software#toc2 Put a shortcut on your desktop for it so we can drag and drop files onto it. This will be much safer than trying to open a file from within the Arduino environment. You can check to make sure this was successful by double clicking the shortcut and seeing if it starts up and assumes it should load a previous build environment.

Next, make a copy of your existing code base so you don't lose anything. In the new folder with what is going to be your new code, drill down into the Marlin directory. Delete all .c, .cpp, .h, .ino and .pde files. Mostly, we are deleting them just to make sure the new files really got put back in place. Download the attached file and change its extension to .ZIP. (The .Zip files can not be as big as we need so I had to use a file extension that can be bigger.) Unzip the attached file and verify you have a directory full of .cpp and .h files in the Marlin folder. This is the current Marlin code base with all of your critical values being used by it. Auto Bed Leveling is turned on and configured however, the Enhanced Auto Bed Leveling is not in it yet. We will do that after we confirm this works as expected.

Go into the Marlin directory and drag and drop the Marlin.pde file onto your Arduino v1.05 shortcut. You should see all the files get loaded. Go to the Tools tab and set the appropriate board type for your printer. It would not compile for my system because the LCD panel has a lot of bloat code. I had to change it to an Atmega-256 type chip.

Do a Sketch / Verify & Compile. If it compiles clean you should be ready to see if this build will work on your printer as expected. As soon as we get this working correctly, we will cross the Enhanced code base into it.

[AbuMaia]

No, the Y axis moves during Z lift during G28.

Issuing an M114 after a G28 gives me:

>>>G28
SENDING:G28
>>>M114
SENDING:M114
X:0.00 Y:0.00 Z:10.70 E:0.00 Count X: 0.00 Y:0.00 Z:10.70 (still using stock marlin without enhanced bed levelling)

Issuing a G29, the LCD reports first probe position as X0 Y37. Pronterface reports Bed x: 30.00 y: 30.00.

[Roxy]

So I'm confused. We had that debug info printing in the G28 command and it was reporting that the Y-Axis was staying at 0.0 and at the very end of the G28 the Y-Axis was still at 0.0?

[AbuMaia]

Yes. Y axis homes, gets set to 0, then while Z axis moves before extending the probe, Y axis also moves, about 10mm, but stays set at 0. So Y axis coordinates are offset by 10mm after a G28, before G29. That's why, when doing the last row of levelling probes during a G29, the probe is right on the edge of the glass (197mm) while the LCD reports it at 187mm.

[RobH2]

Hey Roxy, this in an incredible and valuable thread. There is an amazing amount of expertise being conveyed here.

However, it's gotten quite daunting if someone finds it and wants to digest it. I think it would be a lot of work but do you think it would be possible to make a single post that consolidates all of the advice and tweaks that this thread represents? Your code has evolved during the course of the thread and it's confusing what's new and what's old at times. If you could post a summary and directive it would be really helpful. That would make a good "Sticky." Then we could continue a separate thread that addresses individual issues and continuing problems.

Just a thought.... Really nice work and amazing guidance!

[Roxy]

Thanks for the kind words... Yeah, this thread has grown too big for its own good. Probably it should be broken into 5 or 6 smaller threads. The problem is I am too darn busy. And what I'm thinking is both the M48 Z-Probe Repeatability code and the Enhanced G29 Bed Leveling code need to be repackaged so they can be folded back into the main code base. Somebody suggested (asked) if that had been done and explained the steps to make that happen. I can't find that now. I've been looking at any thread that has GitHub and Put in it.

But anyway, I'm thinking of trying to fold the M48 Z-Probe Repeatability code back into the code base first. The reason is it is smaller, less controversial and has less conflicts with the existing code base. If I can get that 'absorbed', then I was going to try to get the bigger, fatter Enhanced G29 incorporated.

The problem is... I can't find that post with the step by step directions. And if I remember right, it was in some thread that was related, but not actually in one of these sticky threads.

Maybe if the person that typed in those steps sees this message, they can say "Its over here..." ????

Arrrggghhhh! It sucks when you know what you need is within grasp, but you can't quite grab it!!!

[RobH2]

Arrrggghhhh! It sucks when you know what you need is within grasp, but you can't quite grab it!!!

Yea, I know. That's sort of where I was coming from. I've been watching this closely and I've even gotten confused. I too remember the "step by step" directions but can't seem to find them either. No problem that you are busy. One day when things calm down maybe you can condense it but don't worry about it now. If someone on the web happened to randomly find this thread though I think they'd be very confused and move on. What they'd never realize is what a treasure trove of valuable info it is, if you can sort it out.

I'm sort of busy too but I may take a stab at reading it all the way through again and trying to pull out the final results to make a single post.

[brainscan]

The problem is... I can't find that post with the step by step directions. And if I remember right, it was in some thread that was related, but not actually in one of these sticky threads.

Maybe if the person that typed in those steps sees this message, they can say "Its over here..." ????

Arrrggghhhh! It sucks when you know what you need is within grasp, but you can't quite grab it!!!

Is this it?

Well, I haven't actually done it myself, but it appears the steps would be:

First you need to have a github account and be signed in.

Next, on the Marlin firmware main page (https://github.com/ErikZalm/Marlin), there's a button in the upper right of the page that says "Fork". Hit this and it will fork a copy of the firmware to your github account.

Make your changes in your copy, commit them, and verify everything works as it should.

Back on the Marlin main page, on the right hand side, there's a link for "Pull Requests" Click on that.

You will see a button "New Pull Request". Hit that.

It gets a little fuzzy at this point because I have nothing to submit, but you should be able to select your fork in your account and make that the pull request.

After that, it's up to the Marlin developers as to when and if they merge your pull request into the main branch.

Bruce

Page 8 near the bottom.

[Roxy]

SCORE!!! Thanks BrainScan!!!

[brucehvn]

Ha, I was just about to point that out. Brainscan beat me to my own post