Auto_Bed_Leveling: Enhanced G29 command

[AbuMaia]

I did already answer your question, before the edit. Yes, I'm running the enhanced code. I'll be available tomorrow after 12 noon mountain time.

[brucehvn]

I did already answer your question, before the edit. Yes, I'm running the enhanced code. I'll be available tomorrow after 12 noon mountain time.

What I don't think I saw in the conversation was whether you were using the auto bed leveling code before adding Roxy's enhancements and if so, did the problem exist then?

[AbuMaia]

Yes, I was using auto bed levelling before I added the enhanced code. No, the Y axis movement is not a bug of the enhancement code.

[Roxy]

I did already answer your question, before the edit. Yes, I'm running the enhanced code. I'll be available tomorrow after 12 noon mountain time.

OK. Is it possible to do a quick video of the behavior? That would be helpful, but I understand if you can't make that happen. How about you post your Marlin_main.cpp file also. At worst case, I can build your firmware and see if I can duplicate the behavior.

One way or the other, we will skin this cat. Hopefully, it goes quickly.

[AbuMaia]

OK. Is it possible to do a quick video of the behavior?

Video is uploading. It will be at http://youtu.be/H1fGJysek4M when it's done.

Here is my Marlin_main.cpp.

[Roxy]

I think I see the problem. But I haven't spent enough time looking at it to be sure. What I'm going to do is clean up your Marlin_Main.cpp file and send it back to you. (You will get some other goodies like the M48 command at the same time <---<<< Not True! You already had that in there!)

I suspect the problem is you put the 'optional' Z_RAISE code after homing in the wrong place. In particular... I have not looked at it enough to be positive, but these instructions got implemented at a similar, but not correct spot in the Marlen_Main.cpp file:

This step is also optional. Because of how some people's Z-Probe is constructed, it is best to raise the nozzle prior to retracting the probe. The Enhanced G29 code handles this circumstance. But as it turns out, the stock G28 command is also guilty of this bad behavior. If you need the G28 command to raise the nozzle prior to retracting the probe, make the following changes in Marlin_Main.cpp :


Find the following code:
// Retract Servo endstop if enabled

I left the Blocking move you put at the end of the G30. Probably that makes sense to have there. (Maybe I should add it to the instructions on the first page of this thread???) But I have one caution for you. The way the Blocking Move routines work is they use the current_position[] array to know where to start from and they modify it at their completion. There are only certain places and conditions where you can use these functions. I think this funny Y-Axis behavior is a result of having them in the wrong places. (I'm not absolutely positive about that... But I have seen similar types of issue when not being real careful about how they are used.)


----------
UPDATE: I've attached the cleaned up code. Please save your old file so you don't lose it and rename this file Marlin_Main.cpp and put it in your build directory. See if it compiles cleanly. (It should... I was pretty careful crossing over the changes, but it is easy to make a mistake.) If it builds OK, please load it into your printer and see if it behaves better. But be ready to press the RESET button if the nozzle does anything you don't expect!!!!

Are we getting closer to the correct behavior????