Auto_Bed_Leveling: Z-Probe Repeatability code

[Roxy]

@roxy

didn't you manage to get this merged into the main branch of marlin?

I vaguely remember seeing this get merged

Yes, this is in the main line code now. But some how, I poisoned the well. I got the M48 pushed back (and accepted). But now, I can't push anything else back up to be reviewed and accepted. That is why I was hoping DACB would push his fork back up. That would get most of the G28 enhancements accepted into the main line code.

We need somebody to step up and take a bullet for the team!

[sniffle]

Yes, this is in the main line code now. But some how, I poisoned the well. I got the M48 pushed back (and accepted). But now, I can't push anything else back up to be reviewed and accepted. That is why I was hoping DACB would push his fork back up. That would get most of the G28 enhancements accepted into the main line code.

We need somebody to step up and take a bullet for the team!

You need to go to the git shell for the durectory location of your marlin fork on you computer and do

git pull upstream Development

That should catch your version of git up to the current marlin fork.

Then you sync(using the windows github program) for your fork and it will catch your online version up to the online version of marlin

Then you can make changes to your marlin fork to add the next change commit it then sync the change to your fork online thryou can do a pull request...

Ill handle the g29 enhancements just letting you know thats how it works

[Roxy]

ill handle the g29 enhancements just letting you know thats how it works

thank you so much!!!!

[sniffle]

So the only thing that needs to be added are the g29 enhancements ill see what i can do. I dont see a point in doing the g29 eeprom

[lrpirlet]

Hi Roxy
Thanks for this code...
I would suggest to modify the "n" parameter to u or U just like in the G29 code. I am using repetier and could not pass a lower case n...
So the code becomes
// Usage: M48 <n #_samples> <X X_position_for_samples> <Y Y_position_for_samples> <V Verbose_Level> <Engage_probe_for_each_reading> <L legs_of_movement_prior_to_doing_probe>
//
//n (u & U) Controls the number of samples u & U were added because of deficiencies in the Repetier client
// not being able to use even a lower case n

in the comments and

if ( code_seen('n') || code_seen('U') || code_seen('u') ) {

in the code.

This would make M48 more coherent to G29.

Regards.

LRP
P.S. I did not check if that was proposed yet. Juts forgive that if I duplicated

[Roxy]

Hi Roxy
Thanks for this code...
I would suggest to modify the "n" parameter to u or U just like in the G29 code. I am using repetier and could not pass a lower case n...
So the code becomes
...

You are welcome! And the 'new' parameter going forward is going to be 'P'. This code (and feature set) has been pulled into the main line code base at https://github.com/MarlinFirmware/Marlin

[CptanPanic]

I finally got this code, actually the one that got merged into Marlin baseline, and also got my new proximity sensor working good. Here is my topology report. I am not sure what I need to do to fix this on my Prusa i3. Any ideas?

Recv: +-----------+
Recv: |...Back....|
Recv: |Left..Right|
Recv: |...Front...|
Recv: +-----------+
Recv: +0.12169 -0.41244 -1.00194
Recv: +0.43792 +0.01525 -0.49263
Recv: +0.70117 +0.39496 +0.23601
Recv:
Recv: planeNormal x: 0.005914 y: 0.005028 z: 1.000000
Recv:
Recv:
Recv: Bed Level Correction Matrix:
Recv: +0.999983 +0.000000 -0.005914
Recv: -0.000030 +0.999987 -0.005028
Recv: +0.005914 +0.005028 +0.999970

[Roxy]

There may be a small issue with this code... Please post the Marlin_main.cpp file. If there is a problem, I'll edit it for you. But "Yes..." This is the code base you should be using now.

[revwarguy]

Was there any version of this adapted for a delta?

[Roxy]

Was there any version of this adapted for a delta?

This code should work just fine with a Delta printer. However, with that said, my suspicion is that Delta printers are more susceptible to repeatability problems caused by different types of movements. If we knew what types of movements exposed those repeatability issues in Delta printers it might make sense to add a Delta option to the M48 command so the printer could be stressed harder.

With that said... It should work just fine and you should get a number to help you understand how good or bad your mechanics are.